880 Data Provider Framework in Intersection Module #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgenherje
force-pushed
the
880-intersection-module-layer-framework-NEW
branch
4 times, most recently
from
6aef083 to
b58963c
Compare
- Fixes after rebase - WIP
- Make correct viewport - Fix correct viewport for `handleFitInViewClick`, make use of bounds instead of referenceSystem, as bounds include extensionLength
Change: Remove conditional rendering for ViewportWrapper Note: Does not explain why context issue occurs
- Sort available settings arrays for options ordered alphabetically - Make use of TimeOrIntervalSetting for formatting of label in Dropdown
- Handle inf, nan, MAX_VALUE etc to ensure valid bounds and viewport
jorgenherje
force-pushed
the
880-intersection-module-layer-framework-NEW
branch
from
b58963c to
b4fd8c9
Compare
- Undo incorrect package update - Update autogen code - Add adjusted preview code done in original module code
jorgenherje
force-pushed
the
880-intersection-module-layer-framework-NEW
branch
from
b4fd8c9 to
dcdc748
Compare
- Create new viewport when changing intersection or extension length - Handle vertical scale/zFactor when creating viewport.
…ule-layer-framework-NEW
- Move calculation of viewport into wrapper - Refocus view when changing intersection/extension - Introduce fit in view mode - Do not reset/refocus view when adding layers etc unless fit in view mode is on
To prevent duplicate div refs
Anders2303
requested changes
May 28, 2025
...tend/src/modules/Intersection/DataProviderFramework/boundingBoxes/makeSurfacesBoundingBox.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/_shared/components/EsvIntersection/utils/validationUtils.ts
Outdated
Show resolved
Hide resolved
Calculate bbox using fetched data, ensuring bbox is calculated with valid data. I.e. data inside surface
Anders2303
reviewed
Jun 3, 2025
...les/Intersection/DataProviderFramework/boundingBoxes/makeSurfacesUncertaintiesBoundingBox.ts
Outdated
Show resolved
Hide resolved
Anders2303
requested changes
Jun 3, 2025
...nd/src/modules/_shared/DataProviderFramework/settings/implementations/SliderNumberSettig.tsx
Outdated
Show resolved
Hide resolved
- Have min width - Control visibility of input component if setting/drawer width is too small
If no layers are visible or loading, the reference system is creating focus bounds
HansKallekleiv
approved these changes
Jun 3, 2025
…ule-layer-framework-NEW
…le-layer-framework-NEW
…ule-layer-framework-NEW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply data provider framework to Intersection Module
This is a first version only supporting 1 view using the
EsvIntersection-component.Made settings and providers for new functionality. Adjustments to existing
SeismicLayerto perform async generating seismic image.Fixes made compared to old version:
Adjustment/fixes in back-end:
Closes: #880